linux-kernel - Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A3F978C.1050201@novell.com>
Date:	Mon, 22 Jun 2009 10:39:08 -0400
From:	Gregory Haskins <ghaskins@...ell.com>
To:	Avi Kivity <avi@...hat.com>
CC:	Gregory Haskins <gregory.haskins@...il.com>,
	"Michael S. Tsirkin" <mst@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org, mtosatti@...hat.com,
	paulmck@...ux.vnet.ibm.com, markmc@...hat.com
Subject: Re: [KVM PATCH v8 3/3] KVM: add iosignalfd support

Avi Kivity wrote:
> On 06/22/2009 04:19 PM, Gregory Haskins wrote:
>> The question to ask is whether a guest can influence that condition.  If
>> they can, its an attack vector to crash the host.  I suspect they can't,
>> however.  Therefore, your recommendation is perhaps a good approach so
>> this condition cannot ever go unnoticed.  Avi?
>>    
>
> No, this is host memory in the emulator context, allocated as unsigned
> long.  But this is on x86 which isn't sensitive to alignment anyway.

Ok, will change to BUG_ON in v9

> It's unlikely that other achitectures will supply unaligned pointers.
>
Yeah, they shouldn't

> We ought to convert the interface to pass a value anyway.
>
Agreed.  As you said earlier, lets defer for now.

Thanks Avi,
-Greg


Download attachment "signature.asc" of type "application/pgp-signature" (267 bytes)