linux-kernel - Re: [uClinux-dev] [PATCH] m68k: restore lost coldfire CLOCK_TICK_RATE

Open Source and information security mailing list archives

Message-ID: <4A3EF81F.1060300@snapgear.com>
Date:	Mon, 22 Jun 2009 13:18:55 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	uClinux development list <uclinux-dev@...inux.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [uClinux-dev] [PATCH] m68k: restore lost coldfire CLOCK_TICK_RATE

HI Philippe,

Philippe De Muyter wrote:
> Hello list,
> 
> The good definition of CLOCK_TICK_RATE for coldfires has been lost in the
> merge of m68k and m68knommu include files.  Restore it.  Culprit :
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ebafc17468d58bd903c886175ca84a4edc69ae1d;hp=34055b806a6334624e7e8af6eefc3aee42372a85
> 
> Signed-off-by: Philippe De Muyter <phdm@...qel.be>

Is it needed?
What is broken with the existing value?

Regards
Greg

> diff -r 8dcc271a81a8 arch/m68k/include/asm/timex.h
> --- a/arch/m68k/include/asm/timex.h	Thu Jun 18 14:07:46 2009 -0700
> +++ b/arch/m68k/include/asm/timex.h	Sat Jun 20 21:46:25 2009 +0200
> @@ -3,10 +3,23 @@
>   *
>   * m68k architecture timex specifications
>   */
> -#ifndef _ASMm68k_TIMEX_H
> -#define _ASMm68k_TIMEX_H
> +#ifndef _ASMm68K_TIMEX_H
> +#define _ASMm68K_TIMEX_H
>  
> +#ifdef CONFIG_COLDFIRE
> +/*
> + * CLOCK_TICK_RATE should give the underlying frequency of the tick timer
> + * to make ntp work best.  For Coldfires, that's the main clock.
> + */
> +#include <asm/coldfire.h>
> +#define CLOCK_TICK_RATE	MCF_CLK
> +#else
> +/*
> + * This default CLOCK_TICK_RATE is probably wrong for many 68k boards
> + * Users of those boards will need to check and modify accordingly
> + */
>  #define CLOCK_TICK_RATE	1193180 /* Underlying HZ */
> +#endif
>  
>  typedef unsigned long cycles_t;
>  
> _______________________________________________
> uClinux-dev mailing list
> uClinux-dev@...inux.org
> http://mailman.uclinux.org/mailman/listinfo/uclinux-dev
> This message was resent by uclinux-dev@...inux.org
> To unsubscribe see:
> http://mailman.uclinux.org/mailman/options/uclinux-dev
> 

-- 
------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives