linux-kernel - Re: [PATCH 15/20] io-controller: map async requests to appropriate cgroup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090622153910.GB15600@redhat.com>
Date:	Mon, 22 Jun 2009 11:39:10 -0400
From:	Vivek Goyal <vgoyal@...hat.com>
To:	Gui Jianfeng <guijianfeng@...fujitsu.com>
Cc:	linux-kernel@...r.kernel.org,
	containers@...ts.linux-foundation.org, dm-devel@...hat.com,
	jens.axboe@...cle.com, nauman@...gle.com, dpshah@...gle.com,
	lizf@...fujitsu.com, mikew@...gle.com, fchecconi@...il.com,
	paolo.valente@...more.it, ryov@...inux.co.jp,
	fernando@....ntt.co.jp, s-uchida@...jp.nec.com, taka@...inux.co.jp,
	jmoyer@...hat.com, dhaval@...ux.vnet.ibm.com,
	balbir@...ux.vnet.ibm.com, righi.andrea@...il.com,
	m-ikeda@...jp.nec.com, jbaron@...hat.com, agk@...hat.com,
	snitzer@...hat.com, akpm@...ux-foundation.org, peterz@...radead.org
Subject: Re: [PATCH 15/20] io-controller: map async requests to appropriate
	cgroup

On Mon, Jun 22, 2009 at 09:45:41AM +0800, Gui Jianfeng wrote:
> Vivek Goyal wrote:
> > o So far we were assuming that a bio/rq belongs to the task who is submitting
> >   it. It did not hold good in case of async writes. This patch makes use of
> >   blkio_cgroup pataches to attribute the aysnc writes to right group instead
> >   of task submitting the bio.
> > 
> > o For sync requests, we continue to assume that io belongs to the task
> >   submitting it. Only in case of async requests, we make use of io tracking
> >   patches to track the owner cgroup.
> > 
> > o So far cfq always caches the async queue pointer. With async requests now
> >   not necessarily being tied to submitting task io context, caching the
> >   pointer will not help for async queues. This patch introduces a new config
> >   option CONFIG_TRACK_ASYNC_CONTEXT. If this option is not set, cfq retains
> >   old behavior where async queue pointer is cached in task context. If it
> >   is not set, async queue pointer is not cached and we take help of bio
> 
> Here "If it is not set" should be "If it is set".

Yes, in last line it should be "If it is set". Thanks Gui. Will fix the
comment.

Vivek
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/