| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <25e057c00906220847t15425f38maf486c291d1d2468@mail.gmail.com> Date: Mon, 22 Jun 2009 17:47:07 +0200 From: roel kluin <roel.kluin@...il.com> To: Ingo Molnar <mingo@...e.hu> Cc: git@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>, Andrew Morton <akpm@...ux-foundation.org> Subject: Re: [PATCH] tools: fread does not return negative on error On Mon, Jun 22, 2009 at 5:34 PM, Ingo Molnar<mingo@...e.hu> wrote: > > * Roel Kluin <roel.kluin@...il.com> wrote: > >> size_t res cannot be less than 0. fread returns 0 on error. >> >> Signed-off-by: Roel Kluin <roel.kluin@...il.com> >> --- >> Is this correct? please review. >> >> diff --git a/tools/perf/util/strbuf.c b/tools/perf/util/strbuf.c >> index eaba093..376a337 100644 >> --- a/tools/perf/util/strbuf.c >> +++ b/tools/perf/util/strbuf.c >> @@ -259,7 +259,7 @@ size_t strbuf_fread(struct strbuf *sb, size_t size, FILE *f) >> res = fread(sb->buf + sb->len, 1, size, f); >> if (res > 0) >> strbuf_setlen(sb, sb->len + res); >> - else if (res < 0 && oldalloc == 0) >> + else if (res == 0 && oldalloc == 0) >> strbuf_release(sb); >> return res; > > This comes straight from Git's strbuf.c so i've Cc:-ed the Git list. > > Roel, did you get some compiler warning that made you look at this > code? > > Ingo > No, I use sed to catch these bugs. Roel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists