linux-kernel - Re: [PATCH] sound: fix check for return value in snd_pcm_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hmy80olpo.wl%tiwai@suse.de>
Date:	Mon, 22 Jun 2009 07:56:35 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Mariusz Kozlowski <m.kozlowski@...land.pl>
Cc:	Jaroslav Kysela <perex@...ex.cz>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sound: fix check for return value in snd_pcm_hw_refine

At Sun, 21 Jun 2009 20:26:59 +0200,
Mariusz Kozlowski wrote:
> 
> Hello,
> 
> 'params' is a pointer and looking at the code this probably should be a check
> for ioctl return value.
> 
> 	Mariusz
> 
> 
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@...land.pl>

Applied now.  Thanks!


Takashi

> 
> diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
> index 84da3ba..ac2150e 100644
> --- a/sound/core/pcm_native.c
> +++ b/sound/core/pcm_native.c
> @@ -320,7 +320,7 @@ int snd_pcm_hw_refine(struct snd_pcm_substream *substream,
>                      snd_mask_max(&params->masks[SNDRV_PCM_HW_PARAM_CHANNELS])) {
>  			changed = substream->ops->ioctl(substream,
>  					SNDRV_PCM_IOCTL1_FIFO_SIZE, params);
> -			if (params < 0)
> +			if (changed < 0)
>  				return changed;
>  		}
>  	}
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/