linux-kernel - Re: Fix for shared flat binary format in 2.6.30

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <19007.60396.259650.682653@stoffel.org>
Date:	Mon, 22 Jun 2009 16:39:08 -0400
From:	"John Stoffel" <john@...ffel.org>
To:	Linus Torvalds <torvalds@...ux-foundation.org>
Cc:	Bernd Schmidt <bernds_cb1@...nline.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Blackfin Architecture Team 
	<uclinux-dist-devel@...ckfin.uclinux.org>,
	David Howells <dhowells@...hat.com>, stable@...nel.org
Subject: Re: Fix for shared flat binary format in 2.6.30

>>>>> "Linus" == Linus Torvalds <torvalds@...ux-foundation.org> writes:

Linus> On Mon, 22 Jun 2009, Bernd Schmidt wrote:
>> 
>> This fixes a crash in 2.6.30 with shared flat binaries.  prepare_binfmt now
>> requires a cred pointer to be set up, which isn't done in binfmt_flat.c.

Linus> This has so many bugs in patch submission that I literally
Linus> almost gave up despite it being a trivial patch.

I just recently submitted a patch, and it took me a while to figure
out a git flow for stupid, simple patches so that I, a moron, could
understand it.  Here's what I've documented.  Maybe it should be added
to Documentation/SubmittingPatches so that people like me, who only
rarely use git for anything, can use it to submit stuff properly?

###################################################################
# References
http://linux.yyz.us/git-howto.html
http://www.kernel.org/pub/software/scm/git/docs/git-format-patch.html
http://www.kernel.org/pub/software/scm/git/docs/git-send-email.html


# One time commands
> apt-get install git-email
> git config --global user.name "John Stoffel"
> git config --global user.email "john@...ffel.org"

# Only to be done infrequently
> mkdir /var/tmp/git-tree
> cd /var/tmp/git-tree
> git clone git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git linux-2.6



# Make a new branch <branch> for the patch you're doing.  In this
  case, we'll do 'sym_hipd-ratelimit'

> git checkout -b sym_hipd-ratelimit

# Now edit the file

> vi drivers/scsi/sym53c8xx_2/sym_hipd.c
> git commit -a

# Put in a simple message of a line or two.

    ratelimit parity error reporting, which helps alot on bootup over serial
    console when you get 10,000+ lines of this message.

# Now exit the editor

# Check the commit, which is the most recent one by default

> git log -1

# See the actual patch with:

> git diff master..HEAD

# Make a patch you can send out, including any CC: and the signoff (-s)

> git format-patch --cc=linux-scsi@...r.kernel.org --cc=stable@...nel.org -s
0001-ratelimit-parity-error-reporting-which-helps-alot-on.patch

# Now look the patch over and see if you need to edit the subject or
# anything

# In this case, I don't like the commit message
vi 0001-ratelimit-parity-error-reporting-which-helps-alot-on.patch

# Now do a dry run to send the email
> git send-email --dry-run --to=linux-kernel@...r.kernel.org 0001-ratelimit-parity-error-reporting-which-helps-alot-on.patch

# Looks good, send for real
> git send-email --to=linux-kernel@...r.kernel.org 0001-ratelimit-parity-error-reporting-which-helps-alot-on.patch


# Cleanup, got back to the main branch and merge in our change, just
# for fun

> git branch master
> git merge sym_hipd-ratelimit


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/