linux-kernel - Re: FW: [PATCH] cris: remove redundant tests on unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20090623080033.GX12383@axis.com>
Date:	Tue, 23 Jun 2009 10:00:33 +0200
From:	Jesper Nilsson <Jesper.Nilsson@...s.com>
To:	roel.kluin@...il.com, Mikael Starvik <mikael.starvik@...s.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: FW: [PATCH] cris: remove redundant tests on unsigned

Hi,

Looks good, I'll pull it into my CRIS tree.

Thanks!

/Jesper

On Mon, Jun 22, 2009 at 03:11:05PM +0200, Mikael Starvik wrote:
> -----Original Message-----
> From: Roel Kluin [mailto:roel.kluin@...il.com] 
> Sent: den 22 juni 2009 17:07
> To: Mikael Starvik
> Cc: dev-etrax; Andrew Morton
> Subject: [PATCH] cris: remove redundant tests on unsigned
> 
> Since dmanr is unsigned, negatives are wrapped and caught by the other test.
> 
> Signed-off-by: Roel Kluin <roel.kluin@...il.com>
> ---
> diff --git a/arch/cris/arch-v10/kernel/dma.c b/arch/cris/arch-v10/kernel/dma.c
> index 929e686..d31504b 100644
> --- a/arch/cris/arch-v10/kernel/dma.c
> +++ b/arch/cris/arch-v10/kernel/dma.c
> @@ -24,7 +24,7 @@ int cris_request_dma(unsigned int dmanr, const char * device_id,
>  	unsigned long int gens;
>  	int fail = -EINVAL;
>  
> -	if ((dmanr < 0) || (dmanr >= MAX_DMA_CHANNELS)) {
> +	if (dmanr >= MAX_DMA_CHANNELS) {
>  		printk(KERN_CRIT "cris_request_dma: invalid DMA channel %u\n", dmanr);
>  		return -EINVAL;
>  	}
> @@ -213,7 +213,7 @@ int cris_request_dma(unsigned int dmanr, const char * device_id,
>  void cris_free_dma(unsigned int dmanr, const char * device_id)
>  {
>  	unsigned long flags;
> -	if ((dmanr < 0) || (dmanr >= MAX_DMA_CHANNELS)) {
> +	if (dmanr >= MAX_DMA_CHANNELS) {
>  		printk(KERN_CRIT "cris_free_dma: invalid DMA channel %u\n", dmanr);
>  		return;
>  	}
/^JN - Jesper Nilsson
-- 
               Jesper Nilsson -- jesper.nilsson@...s.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/