linux-kernel - Re: PROBLEM: kernel oops with g

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090623102129.3b58adbf@lxorguk.ukuu.org.uk>
Date:	Tue, 23 Jun 2009 10:21:29 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Marek Szyprowski <m.szyprowski@...sung.com>
Cc:	"'David Brownell'" <david-b@...bell.net>,
	"'Alan Stern'" <stern@...land.harvard.edu>,
	"'Peter Korsgaard'" <jacmet@...site.dk>,
	"'USB list'" <linux-usb@...r.kernel.org>,
	"'Kernel development list'" <linux-kernel@...r.kernel.org>,
	kyungmin.park@...sung.com,
	"'Marek Szyprowski'" <m.szyprowski@...sung.com>
Subject: Re: PROBLEM: kernel oops with g_serial USB gadget on 2.6.30

> that g_serial driver interacts with tty layer in that packet_done callback,
> so this is the source of the problems. I noticed that some other UDC
> drivers also does all its job from an interrupt, so they also might be
> affected. How this bug should be properly resolved?

Either by not setting ->low_latency or by running the data paths from a
non IRQ context.

Basically: don't set tty->low_latency if you are handling the processing
from the IRQ path. The only case low_latency is useful is handling data
from a non-IRQ path where you have latency concerns for tx/rx switching.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/