linux-kernel - Re: 2.6.30-git(16 and 17) system hangs after resume from suspend to disk, mce related?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.0906231142540.5287@sister.anvils>
Date:	Tue, 23 Jun 2009 11:54:42 +0100 (BST)
From:	Hugh Dickins <hugh.dickins@...cali.co.uk>
To:	Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
cc:	Maciej Rutecki <maciej.rutecki@...il.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>, "Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: 2.6.30-git(16 and 17) system hangs after resume from suspend to
  disk, mce related?

On Tue, 23 Jun 2009, Hidetoshi Seto wrote:
> Maciej Rutecki wrote:
> > 2009/6/22 Andi Kleen <ak@...ux.intel.com>:
> > 
> >> Here's a debug patch for the poller: http://firstfloor.org/ak/mcp-debug
> >> Can you apply that and try again and send me the output?
> >>
> > 
> > Dmesg after resume:
> > http://unixy.pl/maciek/download/kernel/2.6.30-git17/pc/dmesg-2.6.30-git17-patch.txt
> > 
> > System hangs when uptime is roughly 5-6 minutes (when I don't change
> > check_interval). netconsole doesn't show anything.
> > 
> 
> I found in the dmesg that mce_init() and mce_cpu_features() are called
> on cpu0 twice in short time:
> 
> [   82.989005] mcp on cpu 0 flags 2 banks ecc39e70
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:502
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:506
> [   82.989005] bank 0
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 1
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 2
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 3
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 4
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 5
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] mcp on cpu 0 finished
> [   82.989005] CPU0: Thermal LVT vector (0xfa) already installed
> [   82.989005] PM: Restoring platform NVS memory
> [   82.989005] mcp on cpu 0 flags 2 banks ecc39e70
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:502
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:506
> [   82.989005] bank 0
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 1
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 2
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 3
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 4
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] bank 5
> [   82.989005] [0] arch/x86/kernel/cpu/mcheck/mce.c:518
> [   82.989005] mcp on cpu 0 finished
> [   82.989005] CPU0: Thermal LVT vector (0xfa) already installed
> 
> mce_cpu_features() (which prints "Thermal ...") is always paired with
> mce_init(), and is called only from mcheck_init() and mce_resume().
> 
> One of the above would be from mce_resume(), and if another was from
> mcheck_init(), then setup_timer() in mce_init_timer() will break the
> pending timer...
> 
> [arch/x86/power/cpu.c]
> > static void __restore_processor_state(struct saved_context *ctxt)
> > {
> >  :
> > #ifdef CONFIG_X86_32
> >         mcheck_init(&boot_cpu_data);
> > #endif
> > }
> 
> Hum?
> 
> Maciej, could you try this patch? 

Well found, thanks so much for that, I can confirm that this patch
works for me (though I'm not Maciej).

Since running recent gits on Core2 Duo, following resume from RAM,
within five minutes I'd get either a silent freeze, or a BUG at
kernel/timer.c:911, and/or DEBUG_LIST list.h warnings from
internal_add_timer().

Your patch puts an end to all that.  Something for Andi to rush to
Linus for -rc1 I think - though I won't be in the least surprised if
Andi decides on something a little different, it's rather surprising
to have that mcheck_init() call from over there in just the one case.

Thanks again,
Hugh

> 
> Thanks,
> H.Seto
> 
> ===
> [PATCH] x86: Fix mce resume on 32bit
> 
> Calling mcheck_init() on resume is required only with CONFIG_X86_OLD_MCE=y.
> 
> Signed-off-by: Hidetoshi Seto <seto.hidetoshi@...fujitsu.com>
> ---
>  arch/x86/power/cpu.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/x86/power/cpu.c b/arch/x86/power/cpu.c
> index d277ef1..b3d20b9 100644
> --- a/arch/x86/power/cpu.c
> +++ b/arch/x86/power/cpu.c
> @@ -244,7 +244,7 @@ static void __restore_processor_state(struct saved_context *ctxt)
>  	do_fpu_end();
>  	mtrr_ap_init();
>  
> -#ifdef CONFIG_X86_32
> +#ifdef CONFIG_X86_OLD_MCE
>  	mcheck_init(&boot_cpu_data);
>  #endif
>  }
> -- 
> 1.6.3
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/