linux-kernel - Re: [PATCH] mm/init: cpu_hotplug_init() must be initialized before SLAB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1245719588.17035.42.camel@mulgrave.site>
Date:	Mon, 22 Jun 2009 20:13:08 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>, Sachin Sant <sachinp@...ibm.com>
Subject: Re: [PATCH] mm/init: cpu_hotplug_init() must be initialized before
 SLAB

On Tue, 2009-06-23 at 10:31 +1000, Benjamin Herrenschmidt wrote:
> SLAB uses get/put_online_cpus() which use a mutex which is itself
> only initialized when cpu_hotplug_init() is called. Currently
> we hang suring boot in SLAB due to doing that too late. This
> moves the call to cpu_hotplug_init() to before mm_init() (it
> should be safe to call that early).
> 
> This fixes boot with SLAB on some PowerPC machines.
> 
> Signed-off-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> ---
> 
> Sachin, James, do that fix the boot failures you've been seeing ?

Yes, that seems to fix it for me.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/