lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <4A40CE67.4060504@secunet.com>
Date:	Tue, 23 Jun 2009 14:45:27 +0200
From:	Torsten Hilbrich <torsten.hilbrich@...unet.com>
To:	linux-kernel@...r.kernel.org
CC:	Dave Airlie <airlied@...ux.ie>,
	Zhenyu Wang <zhenyuw@...ux.intel.com>
Subject: [PATCH] drm: Fixes error with gcc 3.3.5 in i915 driver.

When compiling with gcc 3.3.5 I got the following error message in the
module i915.ko:

ERROR: "__udivdi3" [drivers/gpu/drm/i915/i915.ko] undefined!

This error did not occur when compiling the same code in gcc 4.3.2.

This patch replaces the 64 bit division by a call of div_u64 to avoid
triggering the problem on the older compiler.

The code to be fixed was introduced in
commit 2c07245fb8f7f0a282282e5a9747e46defdb2cc7
---
 drivers/gpu/drm/i915/intel_display.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 3e1c781..306d198 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -1502,7 +1502,7 @@ igdng_compute_m_n(int bytes_per_pixel, int nlanes,

 	temp = (u64) DATA_N * pixel_clock;
 	temp = div_u64(temp, link_clock);
-	m_n->gmch_m = (temp * bytes_per_pixel) / nlanes;
+	m_n->gmch_m = div_u64(temp * byte_per_pixel, nlanes);
 	m_n->gmch_n = DATA_N;
 	fdi_reduce_ratio(&m_n->gmch_m, &m_n->gmch_n);

-- 
1.5.4.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ