linux-kernel - Re: [PATCH] synclink_gt fix transmit race and timeout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090623100206.fac4dde7.akpm@linux-foundation.org>
Date:	Tue, 23 Jun 2009 10:02:06 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Paul Fulghum <paulkf@...rogate.com>
Cc:	Alan Cox <alan@...rguk.ukuu.org.uk>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] synclink_gt fix transmit race and timeout

On Tue, 23 Jun 2009 11:55:06 -0600 Paul Fulghum <paulkf@...rogate.com> wrote:

> Andrew Morton wrote:
> > I did have a couple of other comments on the patch which seem to have
> > been missed?
> 
> Let's see, there was:
> "It fails to explain the user-visible effects of the bug which was fixed."

I'm referring to

  Where did the "7" come from?

and

  I have a suspicion that tx_stop() should use del_timer_sync(), not
  del_timer().  What happens if the timer handler is concurrently
  running?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/