| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <4A41ECB8.3060209@hartkopp.net> Date: Wed, 24 Jun 2009 11:07:04 +0200 From: Oliver Hartkopp <socketcan@...tkopp.net> To: Wolfgang Grandegger <wg@...ndegger.com> CC: David Miller <davem@...emloft.net>, heiko.carstens@...ibm.com, schwidefsky@...ibm.com, linux-kernel@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH] can: let SJA1000 driver depend on HAS_IOMEM Wolfgang Grandegger wrote: > Oliver Hartkopp wrote: >> Wolfgang Grandegger wrote: >>> We may even consider making CONFIG_CAN >>> depend on HAS_IOMEM like for SPI, USB, Serial, etc. >> Why CONFIG_CAN ?? >> >> CONFIG_CAN provides a network protocol family that can be used e.g. with the >> vcan driver without any hardware. So HAS_IOMEM only has to take care of some >> drivers, that fiddle on CAN controller registers themselves. E.g. for SPI, USB >> and Serial these 'underlying' interfaces bring their own requirements. When we >> depend on SPI, it should bring HAS_IOMEM as a dependency of SPI. > > OK, then s/CONFIG_CAN/CONFIG_CAN_DEV/ IMHO not even CONFIG_CAN_DEV that also provides bittime calculation and standard CAN driver stuff that does not depend on a specific hardware. HAS_IOMEM should be a dependency on specific drivers (like stated above). Regards, Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists