linux-kernel - Re: [PATCH] PCI: remove pcibios_scan_all

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1245839454.31273.40.camel@zakaz.uk.xensource.com>
Date:	Wed, 24 Jun 2009 11:30:54 +0100
From:	Ian Campbell <Ian.Campbell@...citrix.com>
To:	Jeremy Fitzhardinge <jeremy@...p.org>
CC:	Matthew Wilcox <matthew@....cx>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Alex Chiang <achiang@...com>, <jbarnes@...tuousgeek.org>,
	<linux-arch@...r.kernel.org>, Kyle McMartin <kyle@...artin.ca>,
	Tony Luck <tony.luck@...el.com>,
	Russell King <linux@....linux.org.uk>,
	Arnd Bergmann <arnd@...db.de>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	Jeff Dike <jdike@...toit.com>, <linux-kernel@...r.kernel.org>,
	Ralf Baechle <ralf@...ux-mips.org>,
	David Howells <dhowells@...hat.com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Ingo Molnar <mingo@...hat.com>,
	"David S. Miller" <davem@...emloft.net>,
	Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH] PCI: remove pcibios_scan_all_fns()

On Tue, 2009-06-23 at 13:34 -0700, Jeremy Fitzhardinge wrote:
> On 06/23/09 12:08, Matthew Wilcox wrote:
> > I think simply materialising them, either the way the OF code does,
> > or the way the IOV code does is the best route forwards.
> >   
> 
> On reflection, I think this will work.  We have a Xen pci passthrough
> driver which gets told about the passed-through devices via xenbus, and
> does the appropriate setup.  At first glance, there doesn't seem to be
> any problem with that code just explicitly instantiate the devices at
> the PCI level in the same way pci_scan_device does (ie,
> alloc_pci_device, initalize the dev struct, pci_setup_device).
> 
> Is that what you mean?
> 
> IanC has looked at that code more closely, so perhaps he can confirm
> that this will work on our side.

I'm not 100% familiar with this stuff but pcifront_rescan_root()
currently iterates over all devfns for a bus and calls
pci_scan_single_device(). I don't see where we call pci_scan_slot()
which I think would be the only way pcibios_scan_all_fns() would matter
to us so I'm not sure why we have that patch. It's possible all this has
changed since AlexN originally did the work? It was quite a long time
ago now.

Ian.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/