linux-kernel - Re: [PATCH] perf stat: fix hardcoded nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <1245848217.2681.8.camel@ht.satnam>
Date:	Wed, 24 Jun 2009 18:26:57 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] perf stat: fix hardcoded nr_counter

On Wed, 2009-06-24 at 10:58 +0200, Ingo Molnar wrote:
> * Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:
> 
> > nr_counter should be based on number of default_attrs entries.
> 
> The problem is, this will cause a _lot_ of counters to be used by 
> default, overloading the PMU quite significantly and reducing 
> precision. The number of hw counters is chosen intentionally the way 
> it is now, so that on common hardware there's no over-commit.
> 
> As i suggested before, your change does make sense if introduced as 
> extended event specifications to 'perf stat':
> 
>  -e all
>  -e all-sw-counters
>  -e all-hw-counters
> 
> with regex wildcard support too.
> 

Ok I will support it now.

> Instead, you chose to ignore my feedback and wasted my time by 
> re-sending the same broken patch. If you do such things i'll have to 
> start ignoring you - it is very ineffective for me to repeat every 
> argument and suggestion two or more times and no other contributor 
> does this ...
> 

oops, I am sorry my AMD box was not able to boot because of the
regression the only machine which supports performance counter. I was
doing git-bisect on AMD box in the mean time I prepare this patch on old
Intel box.

> > Remove dead code and some code alignment.
> 
> Could you please send this separately?
> 

Send [PATCH -tip] perf stat: remove dead code

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/