linux-kernel - Re: [PATCH] pata_rdc: driver for RDC ATA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090624174250.6a0dcebe@lxorguk.ukuu.org.uk>
Date:	Wed, 24 Jun 2009 17:42:50 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org, kevin.huang@....com.tw,
	greg@...ah.com
Subject: Re: [PATCH] pata_rdc: driver for RDC ATA devices

> Maybe consolidate?
> 
> The code seems to have many magic constants that might
> be better #define'd and or'd.

If you've got the spec it doesn't go around trying to award hundreds of
bits obscure names so naming them would be silly. If you've not got the
spec then whether its WOMBAT_DERANDOMISE or 0x04 doesn't really make any
difference to your understanding ;)

(And the spec is public)

It's simply a cut down from ata_piix. If you want to clean up ata_piix a
bit then go for it - send patches to Jeff.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/