linux-kernel - Re: [patch 4/6] ide: allow ide_dev_read_id() to be called from the IRQ context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 23 Jun 2009 21:35:35 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	bzolnier@...il.com
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [patch 4/6] ide: allow ide_dev_read_id() to be called from the
 IRQ context

From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Date: Wed, 24 Jun 2009 03:36:24 +0200

> IOW if there are really some technical issues left to be addressed with
> these patches I'll be happy to address them but I'm not doing any more
> new IDE stuff.

Discussing alternative approaches to fixing the problem is a technical
issue.

If you just want to dump your pending fixes and have no interest in
anything other than minor fixups and typo cures, then it's likely most
of these patches will be used only as guides for others rather than
being applied.

Specifically in this case I really think this is a very unclean way to
solve this problem, which is why I suggested alternative
implementations in the first place.

Anything that requires a set of if() blocks checking "in interrupt
context" or not is a big red flag in my book.

But I understand now that you're not willing to work on such things,
which I'll happily respect.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/