linux-kernel - Re: [PATCH] crypto: aes-ni - Don't print message with KERN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090624054302.GA18950@gondor.apana.org.au>
Date:	Wed, 24 Jun 2009 13:43:02 +0800
From:	Herbert Xu <herbert@...dor.apana.org.au>
To:	Roland Dreier <rdreier@...co.com>
Cc:	Huang Ying <ying.huang@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] crypto: aes-ni - Don't print message with KERN_ERR on
	old system

On Tue, Jun 23, 2009 at 10:20:16AM -0700, Roland Dreier wrote:
> When the aes-intel module is loaded on a system that does not have the
> AES instructions, it prints
> 
>     Intel AES-NI instructions are not detected.
> 
> at level KERN_ERR.  Since aes-intel is aliased to "aes" it will be tried
> whenever anything uses AES and spam the console.  This doesn't match
> existing practice for how to handle "no hardware" when initializing a
> module, so downgrade the message to KERN_INFO.
> 
> Signed-off-by: Roland Dreier <rolandd@...co.com>

Patch applied.  Thanks Roland!
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/