linux-kernel - Re: [PATCH] m68k: merge the non-mmu and mmu versions of hardirq.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A432652.9070907@snapgear.com>
Date:	Thu, 25 Jun 2009 17:25:06 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	Arnd Bergmann <arnd@...db.de>
CC:	linux-kernel@...r.kernel.org, gerg@...inux.org,
	linux-m68k@...r.kernel.org
Subject: Re: [PATCH] m68k: merge the non-mmu and mmu versions of hardirq.h

Hi Arnd,

Greg Ungerer wrote:
> Arnd Bergmann wrote:
>> On Wednesday 17 June 2009, Greg Ungerer wrote:
>>> [PATCH] m68k: merge the non-mmu and mmu versions of hardirq.h
>>>
>>> There is nothing different required between the non-mmu and mmu
>>> versions of hardirq.h, so merge them back into a single file.
>>>
>>> Signed-off-by: Greg Ungerer <gerg@...inux.org>
>>
>> AFAICT this file is also the same in the new asm-generic version, so you
>> could fall back to that directly.
> 
> Indeed it could. It will need a clean out of ack_bad_irq() in
> arch/m68knommu/kernel.irq.c, but otherwise looks good.
> 
> I'll prepare a new patch that uses that.

This turns out not to be as trivial as I first thought.

The include of linux/irq.h in the asm-generic/hardirq.h
causes all sorts of include ordering problems for the m68k
hardirq.h. The m68k hardirq.h includes asm/irq.h instead.

Regards
Greg


------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/