linux-kernel - Re: [uClinux-dev] [PATCH] m68k: restore lost coldfire CLOCK_TICK

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A42C5DC.1040103@snapgear.com>
Date:	Thu, 25 Jun 2009 10:33:32 +1000
From:	Greg Ungerer <gerg@...pgear.com>
To:	uClinux development list <uclinux-dev@...inux.org>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [uClinux-dev] [PATCH] m68k: restore lost coldfire CLOCK_TICK_RATE

Hi Philippe,

Philippe De Muyter wrote:
> Hi Greg,
> 
> On Mon, Jun 22, 2009 at 01:18:55PM +1000, Greg Ungerer wrote:
>> HI Philippe,
>>
>> Philippe De Muyter wrote:
>>> Hello list,
>>> The good definition of CLOCK_TICK_RATE for coldfires has been lost in the
>>> merge of m68k and m68knommu include files.  Restore it.  Culprit :
>>> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=ebafc17468d58bd903c886175ca84a4edc69ae1d;hp=34055b806a6334624e7e8af6eefc3aee42372a85
>>> Signed-off-by: Philippe De Muyter <phdm@...qel.be>
>> Is it needed?
>> What is broken with the existing value?
> 
> I am no ntp expert, but IIRC kernel/time/ntp.c needs to know the remainder
> of CLOCK_TICK_RATE / HZ to obtain a good stability of the time.  That's
> probably only needed when you have ntpd running.

I thought it did that based on gettimeofday()?  And that ends up
going through the underlying timer code, which for both of
the ColdFire timer types doesn't use CLOCK_TICK_RATE. They directly
use the MCF_CLK definition.

Regards
Greg



------------------------------------------------------------------------
Greg Ungerer  --  Principal Engineer        EMAIL:     gerg@...pgear.com
SnapGear Group, McAfee                      PHONE:       +61 7 3435 2888
825 Stanley St,                             FAX:         +61 7 3891 3630
Woolloongabba, QLD, 4102, Australia         WEB: http://www.SnapGear.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/