linux-kernel - Re: [PATCH] radeon: preallocate memory for command stream parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Jun 2009 11:03:56 +0200
From:	Thomas Hellström <thomas@...pmail.org>
To:	Pekka Enberg <penberg@...helsinki.fi>
CC:	Jerome Glisse <glisse@...edesktop.org>,
	Nick Piggin <npiggin@...e.de>,
	Jerome Glisse <jglisse@...hat.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, dri-devel@...ts.sf.net
Subject: Re: [PATCH] radeon: preallocate memory for command stream parsing

Pekka Enberg skrev:
> Hi Jerome,
>
> On Tue, 2009-06-23 at 22:52 +0300, Pekka Enberg wrote:
>   
>>> On Tue, Jun 23, 2009 at 10:46 PM, Jerome Glisse<jglisse@...hat.com> wrote:
>>>       
>>>> Command stream parsing is the most common operation and can
>>>> happen hundred of times per second, we don't want to allocate/free
>>>> memory each time this ioctl is call. This rework the ioctl
>>>> to avoid doing so by allocating temporary memory along the
>>>> ib pool.
>>>>
>>>> Signed-off-by: Jerome Glisse <jglisse@...hat.com>
>>>>         
>>> So how much does this help (i.e. where are the numbers)? I am bit
>>> surprised "hundred of times per second" is an issue for our slab
>>> allocators. Hmm?
>>>       
>
> On Wed, 2009-06-24 at 10:29 +0200, Jerome Glisse wrote:
>   
>> I didn't have real number but the vmap path was really slower,
>> quake3 fps goes from ~20 to ~40 on average when going from vmap
>> to preallocated. When using kmalloc i don't thing there was so
>> much performance hit. But i think the biggest hit was that in
>> previous code i asked for zeroed memory so i am pretty sure kernel
>> spend a bit of time clearing page. I reworked the code to avoid
>> needing cleared memory and so avoid memset, this is likely why
>> we get a performance boost.
>>     
>
> OK. If kmalloc() (without memset) really was too slow for your case, I'd
> be interested in looking at it in more detail. I'm not completely
> convinced the memory pool is needed here but I'm not a DRM expert so I'm
> not NAK'ing this either...
>
> 			Pekka
>
>   
Hi!
 From previous experience with other drivers kmalloc() is just fine 
performance-wise.
I've also never seen memsetting pages turn up on the profile. It would 
be interesting to see an oprofile timing of this to try and pinpoint 
what's happening.

However, in this case, I believe Jerome was forced to use vmalloc to 
guarantee that the allocation would succeed, and frequent vmallocs seem 
to be a performance killer.

One should also be careful about frame-rates. Tuning memory manager / 
command submission operation is usually a matter of how much CPU is 
consumed for a given framerate. If one compares framerates one must make 
sure that the CPU is at nearly 100% while benchmarking.

/Thomas



> ------------------------------------------------------------------------------
> --
> _______________________________________________
> Dri-devel mailing list
> Dri-devel@...ts.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/dri-devel
>   

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/