linux-kernel - Re: [RFC PATCH 1/2] pci: determine CLS more intelligently

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090625.020507.203808859.davem@davemloft.net>
Date:	Thu, 25 Jun 2009 02:05:07 -0700 (PDT)
From:	David Miller <davem@...emloft.net>
To:	tj@...nel.org
Cc:	greg@...ah.com, hancockr@...w.ca, alan@...rguk.ukuu.org.uk,
	linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
	daniel.ritz@....ch, linux@...inikbrodowski.net,
	kaneshige.kenji@...fujitsu.com, towerlexa@....de,
	benh@...nel.crashing.org, mingo@...e.hu, tglx@...utronix.de,
	tony.luck@...el.com
Subject: Re: [RFC PATCH 1/2] pci: determine CLS more intelligently

From: Tejun Heo <tj@...nel.org>
Date: Thu, 25 Jun 2009 16:12:13 +0900

> sparc64 is currently the only one using PCI_CACHE_LINE_BYTES.

Feel free to add the patch below and:

Acked-by: David S. Miller <davem@...emloft.net>

Although I think it's better to declare pci_dfl_cache_line_size in
linux/pci.h instead of making every arch do the extern decl.

diff --git a/arch/sparc/kernel/pci.c b/arch/sparc/kernel/pci.c
index 57859ad..511a592 100644
--- a/arch/sparc/kernel/pci.c
+++ b/arch/sparc/kernel/pci.c
@@ -1081,3 +1081,12 @@ void pci_resource_to_user(const struct pci_dev *pdev, int bar,
 	*start = rp->start - offset;
 	*end = rp->end - offset;
 }
+
+extern u8 pci_dfl_cache_line_size;
+
+static int __init pcibios_init(void)
+{
+	pci_dfl_cache_line_size = 64 >> 2;
+	return 0;
+}
+subsys_initcall(pcibios_init);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/