linux-kernel - Re: [PATCH] kvm: remove in_range from kvm_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4A43795D.1080501@novell.com>
Date:	Thu, 25 Jun 2009 09:19:25 -0400
From:	Gregory Haskins <ghaskins@...ell.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
CC:	Gregory Haskins <ghaskins@...ell.com>, avi@...hat.com,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	mtosatti@...hat.com, paulmck@...ux.vnet.ibm.com, markmc@...hat.com
Subject: Re: [PATCH] kvm: remove in_range from kvm_io_device

Michael S. Tsirkin wrote:
> On Thu, Jun 25, 2009 at 09:02:28AM -0400, Gregory Haskins wrote:
>   
>>> Here's what I have in mind:
>>> kvm does
>>> 	lock
>>> 	dev = find
>>> 	unlock
>>>
>>> 	<---------- at this point group device is removed
>>>
>>> 	write access to device that has been removed
>>>
>>>
>>>   
>>>       
>> Hmm...you are right.  This looks like it was introduced with that recent
>> locking patch you cited.  Well, I can still fix it now easily by putting
>> an rcu-read-lock around the access.  Longer term we should move to
>> srcu.  Thoughts?
>>
>> -Greg
>>
>>     
>
>
> Some callbacks take kvm mutex lock. So it seems rcu won't work,
> we need srcu.
>
>   

Indeed.  I will put something together.

We should consider merging the io_bus cleanup I have for deregister
support ASAP as well.

-Greg


Download attachment "signature.asc" of type "application/pgp-signature" (267 bytes)