linux-kernel - Re: [PATCH 16/19] drivers/staging: Use PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Jun 2009 07:53:16 -0700
From:	Joe Perches <joe@...ches.com>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...e.de>
Subject: Re: [PATCH 16/19] drivers/staging: Use PCI_VDEVICE

On Thu, 2009-06-25 at 16:24 +0200, Jiri Slaby wrote:
> > --- a/drivers/staging/vt6655/device_main.c
> > +++ b/drivers/staging/vt6655/device_main.c
> > @@ -344,7 +344,7 @@ static CHIP_INFO chip_info_table[]= {
> >  };
> >  
> >  static struct pci_device_id device_id_table[] __devinitdata = {
> > -{ 0x1106, 0x3253, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (int)&chip_info_table[0]},
> > +{ PCI_VDEVICE(VIA, 0x3253), (int)&chip_info_table[0]},
> 
> Hmm, pointer chopped to 4 bytes on 64-bit. Could you fix that up too?

In addition to original patch

drivers/staging/vt6655: cast pci_device_id driver_data to appropriate type
    
Signed-off-by: Joe Perches <joe@...ches.com>

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 7a2377c..a347087 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -344,7 +344,7 @@ static CHIP_INFO chip_info_table[]= {
 };
 
 static struct pci_device_id device_id_table[] __devinitdata = {
-{ PCI_VDEVICE(VIA, 0x3253), (int)&chip_info_table[0]},
+{ PCI_VDEVICE(VIA, 0x3253), (kernel_ulong_t)&chip_info_table[0]},
 { 0, }
 };
 #endif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/