linux-kernel - Re: [KVM PATCH v8 1/3] KVM: make io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4A439029.10601@gmail.com>
Date:	Thu, 25 Jun 2009 10:56:41 -0400
From:	Gregory Haskins <gregory.haskins@...il.com>
To:	"Michael S. Tsirkin" <mst@...hat.com>
CC:	Gregory Haskins <ghaskins@...ell.com>, avi@...hat.com,
	kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
	mtosatti@...hat.com, paulmck@...ux.vnet.ibm.com, markmc@...hat.com
Subject: Re: [KVM PATCH v8 1/3] KVM: make io_bus interface more robust

Michael S. Tsirkin wrote:
> On Thu, Jun 25, 2009 at 10:22:29AM -0400, Gregory Haskins wrote:
>   
>> Gregory Haskins wrote:
>>     
>>> Today kvm_io_bus_regsiter_dev() returns void and will internally BUG_ON if it
>>> fails.  We want to create dynamic MMIO/PIO entries driven from userspace later
>>> in the series, so we need to enhance the code to be more robust with the
>>> following changes:
>>>
>>>    1) Add a return value to the registration function
>>>    2) Fix up all the callsites to check the return code, handle any
>>>       failures, and percolate the error up to the caller.
>>>    3) Add an unregister function that collapses holes in the array
>>>       
>
> Does not unregister need rcu bus fixes to work?
>
>   
Not without users ;)

But, hmm.   Perhaps I should re-split out the return value stuff so it
can go independent of the unregister.  Gah, this io_bus is a nightmare.

-Greg


Download attachment "signature.asc" of type "application/pgp-signature" (267 bytes)