[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <1245945462.9157.11.camel@hpdv5.satnam>
Date: Thu, 25 Jun 2009 21:27:42 +0530
From: Jaswinder Singh Rajput <jaswinder@...nel.org>
To: mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
peterz@...radead.org, jaswinderrajput@...il.com,
tglx@...utronix.de, mingo@...e.hu
Cc: linux-tip-commits@...r.kernel.org
Subject: Re: [tip:perfcounters/urgent] perf_counter tools: Shorten names
for events
Hello Ingo,
On Thu, 2009-06-25 at 15:33 +0000, tip-bot for Jaswinder Singh Rajput
wrote:
> Commit-ID: e5c59547791f171b280bc4c4b2c3ff171824c1a3
> Gitweb: http://git.kernel.org/tip/e5c59547791f171b280bc4c4b2c3ff171824c1a3
> Author: Jaswinder Singh Rajput <jaswinder@...nel.org>
> AuthorDate: Thu, 25 Jun 2009 18:25:22 +0530
> Committer: Ingo Molnar <mingo@...e.hu>
> CommitDate: Thu, 25 Jun 2009 17:30:23 +0200
>
> perf_counter tools: Shorten names for events
>
> Added new alias for events.
>
> On AMD box:
>
> $ ./perf stat -e l1d -e l1d-misses -e l1d-write -e l1d-prefetch -e l1d-prefetch-miss -e l1i -e l1i-misses -e l1i-prefetch -e l2 -e l2-misses -e l2-write -e dtlb -e dtlb-misses -e itlb -e itlb-misses -e bpu -e bpu-misses -- ls -lR /usr/include/ > /dev/null
>
> Before :
>
> Performance counter stats for 'ls -lR /usr/include/':
>
> 248064467 L1-data-Cache-Load-Referencees (scaled from 23.27%)
> 1001433 L1-data-Cache-Load-Misses (scaled from 23.34%)
> 153691 L1-data-Cache-Store-Referencees (scaled from 23.34%)
> 423248 L1-data-Cache-Prefetch-Referencees (scaled from 23.33%)
> 302138 L1-data-Cache-Prefetch-Misses (scaled from 23.25%)
> 251217546 L1-instruction-Cache-Load-Referencees (scaled from 23.25%)
> 5757005 L1-instruction-Cache-Load-Misses (scaled from 23.23%)
> 93435 L1-instruction-Cache-Prefetch-Referencees (scaled from 23.24%)
> 6496073 L2-Cache-Load-Referencees (scaled from 23.32%)
> 609485 L2-Cache-Load-Misses (scaled from 23.45%)
> 6876991 L2-Cache-Store-Referencees (scaled from 23.71%)
> 248922840 Data-TLB-Cache-Load-Referencees (scaled from 23.94%)
> 5828386 Data-TLB-Cache-Load-Misses (scaled from 24.17%)
> 257613506 Instruction-TLB-Cache-Load-Referencees (scaled from 24.20%)
> 6833 Instruction-TLB-Cache-Load-Misses (scaled from 23.88%)
> 109043606 Branch-Cache-Load-Referencees (scaled from 23.64%)
> 5552296 Branch-Cache-Load-Misses (scaled from 23.42%)
>
> 0.413702461 seconds time elapsed.
>
> After :
>
> Peformance counter stats for 'ls -lR /usr/include/':
>
> 266590464 L1-d$-loads (scaled from 23.03%)
> 1222273 L1-d$-load-misses (scaled from 23.58%)
> 146204 L1-d$-stores (scaled from 23.83%)
> 406344 L1-d$-prefetches (scaled from 24.09%)
> 283748 L1-d$-prefetch-misses (scaled from 24.10%)
> 249650965 L1-i$-loads (scaled from 23.80%)
> 3353961 L1-i$-load-misses (scaled from 23.82%)
> 104599 L1-i$-prefetches (scaled from 23.68%)
> 4836405 LLC-loads (scaled from 23.67%)
> 498214 LLC-load-misses (scaled from 23.66%)
> 4953994 LLC-stores (scaled from 23.64%)
> 243354097 dTLB-loads (scaled from 23.77%)
> 6468584 dTLB-load-misses (scaled from 23.74%)
> 249719549 iTLB-loads (scaled from 23.25%)
> 5060 iTLB-load-misses (scaled from 23.00%)
> 112343016 branch-loads (scaled from 22.76%)
> 5528876 branch-load-misses (scaled from 22.54%)
>
> 0.427154051 seconds time elapsed.
>
> Reported-by : Ingo Molnar <mingo@...e.hu>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> Cc: Peter Zijlstra <peterz@...radead.org>
> LKML-Reference: <1245934522.5308.39.camel@...v5.satnam>
> Signed-off-by: Ingo Molnar <mingo@...e.hu>
>
>
> ---
> tools/perf/util/parse-events.c | 45 ++++++++++++++++++++++++---------------
> 1 files changed, 28 insertions(+), 17 deletions(-)
>
> diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
> index 7939a21..430f060 100644
> --- a/tools/perf/util/parse-events.c
> +++ b/tools/perf/util/parse-events.c
> @@ -71,23 +71,23 @@ static char *sw_event_names[] = {
> #define MAX_ALIASES 8
>
> static char *hw_cache[][MAX_ALIASES] = {
> - { "L1-data", "l1-d", "l1d" },
> - { "L1-instruction", "l1-i", "l1i" },
> - { "L2", "l2" },
> - { "Data-TLB", "dtlb", "d-tlb" },
> - { "Instruction-TLB", "itlb", "i-tlb" },
> - { "Branch", "bpu" , "btb", "bpc" },
> + { "L1-d$", "l1-d", "L1-data", },
> + { "L1-i$", "l1-i", "L1-instruction", },
You changed, 'L1d' to 'L1-d$' and 'L1i" to 'L1-i$' so above command is
failing.
[PATCH] perf_counter tools: adding alias for L1D and L1I which was removed ny mistake
By mistake e5c59547791f171 renamed preexisting aliases which leads to failure.
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
---
tools/perf/util/parse-events.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/util/parse-events.c b/tools/perf/util/parse-events.c
index 430f060..4d042f1 100644
--- a/tools/perf/util/parse-events.c
+++ b/tools/perf/util/parse-events.c
@@ -71,8 +71,8 @@ static char *sw_event_names[] = {
#define MAX_ALIASES 8
static char *hw_cache[][MAX_ALIASES] = {
- { "L1-d$", "l1-d", "L1-data", },
- { "L1-i$", "l1-i", "L1-instruction", },
+ { "L1-d$", "l1-d", "l1d", "L1-data", },
+ { "L1-i$", "l1-i", "l1i", "L1-instruction", },
{ "LLC", "L2" },
{ "dTLB", "d-tlb", "Data-TLB", },
{ "iTLB", "i-tlb", "Instruction-TLB", },
--
1.6.0.6
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists