linux-kernel - Re: [PATCH] i2c: fix build bug in i2c-designware.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090625174915.GV6027@tarshish>
Date:	Thu, 25 Jun 2009 20:49:15 +0300
From:	Baruch Siach <baruch@...s.co.il>
To:	Ben Dooks <ben-linux@...ff.org>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: fix build bug in i2c-designware.c

Hi Ben,

On Thu, Jun 25, 2009 at 06:40:00PM +0100, Ben Dooks wrote:
> On Thu, Jun 25, 2009 at 08:32:21AM +0200, Ingo Molnar wrote:
> > >From 8bf467c9f4591f77e1d69bd78fb6cc4f1ff387f8 Mon Sep 17 00:00:00 2001
> > From: Ingo Molnar <mingo@...e.hu>
> > Date: Thu, 25 Jun 2009 08:27:14 +0200
> > Subject: [PATCH] i2c: fix build bug in i2c-designware.c
> > 
> > This build error triggers on x86:
> > 
> >  drivers/built-in.o: In function `i2c_dw_init':
> >  i2c-designware.c:(.text+0x4e37ca): undefined reference to `clk_get_rate'
> >  drivers/built-in.o: In function `dw_i2c_probe':
> >  i2c-designware.c:(.devinit.text+0x51f5e): undefined reference to `clk_get'
> >  i2c-designware.c:(.devinit.text+0x51f76): undefined reference to `clk_enable'
> >  i2c-designware.c:(.devinit.text+0x520ff): undefined reference to `clk_disable'
> >  i2c-designware.c:(.devinit.text+0x52108): undefined reference to `clk_put'
> > 
> > Because this new driver uses the clk_*() facilities which is an
> > ARM-only thing currently.
> > 
> > Signed-off-by: Ingo Molnar <mingo@...e.hu>
> > ---
> >  drivers/i2c/busses/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index d56351a..0760f25 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -334,6 +334,7 @@ config I2C_DAVINCI
> >  
> >  config I2C_DESIGNWARE
> >  	tristate "Synopsys DesignWare"
> > +	depends on HAVE_CLK
> >  	help
> >  	  If you say yes to this option, support will be included for the
> >  	  Synopsys DesignWare I2C adapter. Only master mode is supported.
> 
> thanks, missed there not being a 'depends on' line...
> 
> Baurch - can you submit a patch to declare which ARM architectures that
> this runs on, or whether Ingo's dependency on HAVE_CLK is the fix to merge?

Ingo's fix should be enough.

baruch

-- 
                                                     ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@...s.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/