linux-kernel - Re: [PATCH 2/2] tsc2007: make platform callbacks optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20090625142344.d7c5b72d.akpm@linux-foundation.org>
Date:	Thu, 25 Jun 2009 14:23:44 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Richard Röjfors 
	<richard.rojfors.ext@...ean-labs.com>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	kwangwoo.lee@...il.com, thierry.reding@...onic-design.de,
	soni.trilok@...il.com
Subject: Re: [PATCH 2/2] tsc2007: make platform callbacks optional

On Tue, 23 Jun 2009 13:54:54 +0200
Richard R__jfors <richard.rojfors.ext@...ean-labs.com> wrote:

> The platform callbacks are only called if supplied. Makes the driver
> to fallback on only pressure calculation to decide when the pen is up.
> 

Again, I don't understand the reason for the change from the above
description.

Is there some driver in the tree which does not implement
->get_pendown_state()?  If so, it will oops, won't it?  Which driver is
that?

Or is there some other driver which you're developing which does not
implement ->get_pendown_state()?

If the latter, why should the problem be solved in this way, rather
than implementing an empty ->get_pendown_state() within that driver?

etc.   More details, please.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/