lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Jun 2009 13:12:28 +0900 From: Paul Mundt <lethal@...ux-sh.org> To: Baruch Siach <baruch@...s.co.il> Cc: Stephen Rothwell <sfr@...b.auug.org.au>, Linus <torvalds@...ux-foundation.org>, linux-next@...r.kernel.org, linux-kernel@...r.kernel.org, Andrew Morton <akpm@...ux-foundation.org>, Ben Dooks <ben-linux@...ff.org> Subject: Re: linux-next: origin tree build failure On Thu, Jun 25, 2009 at 06:24:08AM +0300, Baruch Siach wrote: > Hi Stephen, > > On Thu, Jun 25, 2009 at 11:13:44AM +1000, Stephen Rothwell wrote: > > Today's linux-next build (x86_64 allmodconfig) failed like this: > > > > ERROR: "clk_enable" [drivers/i2c/busses/i2c-designware.ko] undefined! > > ERROR: "clk_disable" [drivers/i2c/busses/i2c-designware.ko] undefined! > > ERROR: "clk_put" [drivers/i2c/busses/i2c-designware.ko] undefined! > > ERROR: "clk_get_rate" [drivers/i2c/busses/i2c-designware.ko] undefined! > > ERROR: "clk_get" [drivers/i2c/busses/i2c-designware.ko] undefined! > > > > Caused by commit 1ab52cf910bbbee92861227e6ed77c56b1dc233c ("i2c: driver > > for the Synopsys DesignWare I2C controller") from Linus' tree which I > > have reverted for today. > > So, what is the right configuration symbol to depend on for the clk API? > CONFIG_HAVE_CLK. > A short archives search led to the "provide a dummy implementation of the clk > API" patch from Uwe Kleine-K?nig > (http://lkml.indiana.edu/hypermail/linux/kernel/0804.2/2748.html). Is this the > right solution? > Something like this would be better handled in include/linux/clk.h. One of the things to watch out for is clk_get_rate(), there are cases in the kernel where the rate is fetched with clk_get_rate() and then subsequently used as a divisor in some other equation. clk_get_rate() probably ought to WARN_ON(1) unconditionally, as any driver wanting rate information is going to need proper clock information. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists