linux-kernel - RE: [PATCH] pata_rdc: driver for RDC ATA devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <07905E0D268758488D76D7D747F21BB602B4ED3B@rdc8.rdc>
Date:	Thu, 25 Jun 2009 12:27:18 +0800
From:	Kevin Huang (黃凱文) <Kevin.Huang@....com.tw>
To:	"Alan Cox" <alan@...rguk.ukuu.org.uk>,
	"Jeff Garzik" <jeff@...zik.org>
Cc:	<linux-kernel@...r.kernel.org>, <greg@...ah.com>,
	"Linux IDE mailing list" <linux-ide@...r.kernel.org>
Subject: RE: [PATCH] pata_rdc: driver for RDC ATA devices

At first I studied ata_piix driver for our driver, because we need to testing our controller. Then I found it is hard to me.
I needed to clearify the unreadable code of hardware setting and configuration.
So I just modify and clean up original code. And make it simple for beginner or maintainer. I keep original framework and design for future controllers and updates.

This is my first experience of linux driver . Just for share.


-----Original Message-----
>> Seems fine and fairly straightforward to me.  My lone comment -- go 
>> through and replace magic numbers with named constants, for e.g. the PCI 
>> config registers that program timings...

>Its based on your ata_piix driver. Feel free to update that and I'll pull
>names and things across to match.
---------------------------------------------------------------------------------- 
[E-mail Confidentiality Notice]
The information in this e-mail is confidential and may be legally privileged 
otherwise  protected from disclosure. It is intended solely for the 
addressee.  Access to this e-mail by anyone else is unauthorized .If you
are not the intended recipient, any disclosure, copying, distribution or any 
action taken or omitted to be taken in reliance on it, is prohibited and 
maybe unlawful.  Please delete the message and any attachments from 
your computer system; and destroy all hard copies. 

ALL Intellectual Property Rights of RDC Reserved.
----------------------------------------------------------------------------------