linux-kernel - [PATCH 2.6.30-rc6] Remove kmem_cache_destroy() in s3c24xx_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200906260032.n5Q0WRLE093696@www262.sakura.ne.jp>
Date:	Fri, 26 Jun 2009 09:32:27 +0900
From:	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>
To:	linux-kernel@...r.kernel.org
Subject: [PATCH 2.6.30-rc6] Remove kmem_cache_destroy() in s3c24xx_dma_init().

Would somebody catch this patch?
Maybe it's better to check for NULL inside kmem_cache_destroy()
to avoid NULL pointer dereference at kmem_cache_destroy()...
----------
[PATCH 2.6.30-rc6] Remove kmem_cache_destroy() in s3c24xx_dma_init().

s3c24xx_dma_init() is passing NULL to kmem_cache_destroy() if
kmem_cache_create() failed.
We can remove this kmem_cache_destroy() because it is called only when
kmem_cache_create() failed.

Signed-off-by: Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>
---
 arch/arm/plat-s3c24xx/dma.c |    1 -
 1 file changed, 1 deletion(-)
--- linux-2.6.30-rc6.orig/arch/arm/plat-s3c24xx/dma.c
+++ linux-2.6.30-rc6/arch/arm/plat-s3c24xx/dma.c
@@ -1396,7 +1396,6 @@ int __init s3c24xx_dma_init(unsigned int
 	return 0;

  err:
-	kmem_cache_destroy(dma_kmem);
 	iounmap(dma_base);
 	dma_base = NULL;
 	return ret;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/