linux-kernel - Re: [PATCH 2/9] x86: introduce a set of platform feature flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090626094514.GB12571@elte.hu>
Date:	Fri, 26 Jun 2009 11:45:14 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
Cc:	"Pan, Jacob jun" <jacob.jun.pan@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
Subject: Re: [PATCH 2/9] x86: introduce a set of platform feature flags

* Alan Cox <alan@...rguk.ukuu.org.uk> wrote:

> > Whether a given platform has a 'standard PC' or some custom 
> > driver then depends on that driver's init sequence - it's not a 
> > central thing.
> 
> How exactly do you propose to handle boot memory allocation (eg 
> EBDA) with a driver ? Perhaps you can explain "driverize" as it 
> isn't in any dictionary and I'm not at all clear what you are on 
> about ?

Which bit is not clear? We've been continuously 'driverizing' the 
jumbled mess of x86 platform support code in the past ~1-2 years. 
Things like x86_quirks or struct apic and other similar code 
restructuring and cleanups. They are (of course) not classic 'driver 
core' drivers (many of the core kernel facilities are not available 
yet at this early stage), but properly abstracted, function vector 
driven approaches are still a must.

This series of patches increases the mess in that area, and that's a 
step backwards. It sprinkles the code with a fair amount of 'if 
(feature_x)' conditions instead of cleanly separating out proper 
abstractions.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/