[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <4A44235A.4090503@cn.fujitsu.com>
Date: Fri, 26 Jun 2009 09:24:42 +0800
From: Xiao Guangrong <xiaoguangrong@...fujitsu.com>
To: David Miller <davem@...emloft.net>
CC: nhorman@...driver.com, mingo@...e.hu, fweisbec@...il.com,
linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
rostedt@...dmis.org
Subject: Re: [PATCH v2] ftrace: change the export format of trace_kfree_skb()
David Miller wrote:
> FWIW there are parts I don't like about this change.
>
> It's just the show_protocol_name() bit, it's designed to always be
> out of date.
>
> Nobody is going to look at trace/events/skb.h when they add a new
> ETH_P_* value.
>
> We could make some include/linux/eth_protos.def file, that has
> lines like:
>
> ETHERNET_PROTOCOL(ETH_P_FOO, N)
>
> then headers that want to instantiate something like the usual
> ETH_P_FOO defines or this symbolic printing table define
> "ETHERNET_PROTOCOL" to a suitable macro and then include
> linux/eth_protos.def to make the expansions.
>
Thanks for your review and your nice solution.
I will fix it in next version. ;-)
Thanks,
Xiao
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists