linux-kernel - Re: [PATCH 01/10] percpu: use dynamic percpu allocator as the default percpu allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246029229.3925.20.camel@mulgrave.site>
Date:	Fri, 26 Jun 2009 10:13:49 -0500
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Tejun Heo <tj@...nel.org>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	linux-arch@...r.kernel.org, mingo@...e.hu, kyle@...artin.ca,
	cl@...ux-foundation.org, Jesper.Nilsson@...s.com,
	benh@...nel.crashing.org, paulmck@...ux.vnet.ibm.com,
	rusty@...tcorp.com.au, torvalds@...ux-foundation.org,
	akpm@...ux-foundation.org, Paul Mundt <lethal@...ux-sh.org>,
	Russell King <rmk@....linux.org.uk>,
	Mikael Starvik <starvik@...s.com>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Bryan Wu <cooloney@...nel.org>,
	Matthew Wilcox <matthew@....cx>,
	Grant Grundler <grundler@...isc-linux.org>,
	Hirokazu Takata <takata@...ux-m32r.org>,
	Richard Henderson <rth@...ddle.net>,
	Ivan Kokshaysky <ink@...assic.park.msu.ru>,
	Heiko Carstens <heiko.carstens@...ibm.com>
Subject: Re: [PATCH 01/10] percpu: use dynamic percpu allocator as the
 default percpu allocator

On Thu, 2009-06-25 at 11:55 +0900, Tejun Heo wrote:
> James Bottomley wrote:
> > On Wed, 2009-06-24 at 15:45 +0900, Tejun Heo wrote:
> >> This patch makes most !CONFIG_HAVE_SETUP_PER_CPU_AREA archs use
> >> dynamic percpu allocator.  The first chunk is allocated using
> >> embedding helper and 8k is reserved for modules.  This ensures that
> >> the new allocator behaves almost identically to the original allocator
> >> as long as static percpu variables are concerned, so it shouldn't
> >> introduce much breakage.
> >>
> >> s390 and alpha use custom SHIFT_PERCPU_PTR() to work around addressing
> >> range limit the addressing model imposes.  Unfortunately, this breaks
> >> if the address is specified using a variable, so for now, the two
> >> archs aren't converted.
> >>
> >> The following architectures are affected by this change.
> >>
> >> * sh
> >> * arm
> >> * cris
> >> * mips
> >> * sparc(32)
> >> * blackfin
> >> * avr32
> >> * parisc (broken, under investigation)
> > 
> > OK, I thought I'd investigate this.  Unfortunately, your git tree
> > doesn't build when pulled into head ... could you update?
> > 
> > mm/percpu.c: In function 'setup_per_cpu_areas':
> > mm/percpu.c:2007: error: too many arguments to function 'pcpu_embed_first_chunk'
> 
> Hmm... strange.  I don't see such failures.  Can you please try the
> following git tree?
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/tj/percpu.git for-james
> 
> The contains all posted percpu patches and pulls in the current
> linus#master (rc1).

It still fails with the above error.

If you look at your own file:

http://git.kernel.org/?p=linux/kernel/git/tj/percpu.git;a=blob;f=mm/percpu.c;h=b11ae7af3f7a214717d6670edb2985368efa8391;hb=for-james

on line 1456 pcpu_embed_first_chunk is defined with *three* arguments

on line 2006 it's used with *four* arguments

This is what the compiler doesn't like.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/