[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20090626092001.32e35e17.akpm@linux-foundation.org>
Date: Fri, 26 Jun 2009 09:20:01 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Neil Horman <nhorman@...driver.com>
Cc: linux-kernel@...r.kernel.org, earl_chew@...lent.com,
Oleg Nesterov <oleg@...hat.com>,
Alan Cox <alan@...rguk.ukuu.org.uk>,
Andi Kleen <andi@...stfloor.org>
Subject: Re: [PATCH] exec: Make do_coredump more robust and safer when using
pipes in core_pattern
On Fri, 26 Jun 2009 06:48:04 -0400 Neil Horman <nhorman@...driver.com> wrote:
> > > --- a/kernel/sysctl.c
> > > +++ b/kernel/sysctl.c
> > > @@ -75,6 +75,7 @@ extern int max_threads;
> > > extern int core_uses_pid;
> > > extern int suid_dumpable;
> > > extern char core_pattern[];
> > > +extern unsigned int core_pipe_limit;
> >
> > Bah.
> >
> > We should fix this one day.
> >
> Is there a particular way you'd like to see it fixed?
Not in the context of this patch.
One way would be to add a new sysctl-externs.h and then put all the
declarations in there. That file gets included by sysctl.c and by each
file which shares a global with sysctl.c
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists