linux-kernel - Re: [PATCH] virtio_blk: add missing _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090626123736.594969c8@jbarnes-g45>
Date:	Fri, 26 Jun 2009 12:37:36 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Mike Frysinger <vapier@...too.org>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH] virtio_blk: add missing __dev{init,exit} markings

On Wed, 20 May 2009 00:10:51 +0930
Rusty Russell <rusty@...tcorp.com.au> wrote:

> On Mon, 18 May 2009 05:09:09 pm Mike Frysinger wrote:
> > -static int virtblk_probe(struct virtio_device *vdev)
> > +static int __devinit virtblk_probe(struct virtio_device *vdev)
> 
> This makes sense, I think, but then it implies that
> virtio_dev_probe() should also be __devinit, right?
> 
> And I look at pci_bus_probe(), and it's not __devinit.
> 
> Is the PCI code just slack?

I wouldn't be surprised if some annotations were missing or incorrect
given the churn in hotplug lately, but I can't find that particular
symbol...

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/