linux-kernel - [PATCH 0/2] do_coredump: misc cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090626191418.GA22603@redhat.com>
Date:	Fri, 26 Jun 2009 21:14:18 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>,
	Neil Horman <nhorman@...driver.com>
Cc:	linux-kernel@...r.kernel.org, earl_chew@...lent.com,
	Alan Cox <alan@...rguk.ukuu.org.uk>,
	Andi Kleen <andi@...stfloor.org>,
	Roland McGrath <roland@...hat.com>
Subject: [PATCH 0/2] do_coredump: misc cleanups

On 06/26, Neil Horman wrote:
>
> On Fri, Jun 26, 2009 at 06:59:08PM +0200, Oleg Nesterov wrote:
> >
> > Doesn't look good, if core_pattern starts with "|" any user can set
> > RLIMIT_CORE = 0 and then just do
> >
> > 	for (;;)
> > 		if (pid = fork())
> > 			kill(pid, SIGQUIT);
> >
> > to DOS printk/syslog, no?
> >
> I don't think SIGQUIT will trigger this, but SIGSEGV will.

SIGQUIT falls into SIG_KERNEL_COREDUMP_MASK too.

> Regardless, if you
> do that, I would think you have bigger problems on your system.

OK, agreed.


Neil, I think you are doing useful changes, but can't we cleanup
do_coredump() first?

I just can't look at unnecessary "if (ispipe)" checks...

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/