linux-kernel - Re: [PATCH 1/2] MMC/pxamci: workaround regulator framework bugs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246071323.10360.386.camel@brutus>
Date:	Fri, 26 Jun 2009 23:55:23 -0300
From:	Daniel Ribeiro <drwyrm@...il.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Pierre Ossman <pierre@...man.eu>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Eric Miao <eric.y.miao@...il.com>,
	openezx-devel <openezx-devel@...ts.openezx.org>,
	David Brownell <dbrownell@...rs.sourceforge.net>,
	Liam Girdwood <lrg@...mlogic.co.uk>,
	linux-arm-kernel <linux-arm-kernel@...ts.arm.linux.org.uk>
Subject: Re: [PATCH 1/2] MMC/pxamci: workaround regulator framework bugs

Em Sáb, 2009-06-27 às 01:48 +0100, Mark Brown escreveu:
> > +		/*
> > +		 * When the bootloader leaves a supply active, it's
> > +		 * initialized with zero usecount ... and we can't
> > +		 * disable it without first enabling it.  Until the
> > +		 * framework is fixed, we need a workaround like this
> > +		 * (which is safe for MMC, but not in general).
> 
> This also needs to explain the actual situation, especially the
> exclusivity reqirement of the MMC core.  It might be worth providing a
> helper in the MMC core, everything is going to need to be updated to use
> exclusive get whenever someone implements it.

Heh, this patch was copy-n-paste from twl code. I really can't put much
time on this. :(

> As discussed at some length the regulator API is not going to be changed
> in the way you demand.  This is not something that it should be easy for
> standard consumers to do since for standard consumers it normally points
> out a programming error.

Ok, so I will "fix it" hacking the bootloader to power off the voltage
regulator before giving control to kernel. Lets hope that the next
developer that tries to use the regulator framework with a mmc card and
stumbles on the "regulator already enabled" case has more time to fix it
properly. :)

-- 
Daniel Ribeiro

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)