linux-kernel - Re: [PATCH] IDE: ide-taskfile.c fix compilation warning and cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246094308.2961.15.camel@hpdv5.satnam>
Date:	Sat, 27 Jun 2009 14:48:28 +0530
From:	Jaswinder Singh Rajput <jaswinder@...nel.org>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] IDE: ide-taskfile.c fix compilation warning and cleanup

Hello Bart, David,

On Fri, 2009-06-26 at 21:42 +0200, Bartlomiej Zolnierkiewicz wrote:
> On Friday 26 June 2009 05:18:10 Jaswinder Singh Rajput wrote:
> > On Mon, 2009-06-22 at 12:50 +0200, Bartlomiej Zolnierkiewicz wrote:
> 
> > > Besides I would suggest splitting the patch on fix and cleanup parts.
> > 
> > Here is the cleanup part:
> > 
> > [PATCH] IDE: ide-taskfile.c fix style problems
> > 
> > Fix trivial style problems:
> > 
> > WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
> > WARNING: space prohibited between function name and open parenthesis '('
> > WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable
> > ERROR: do not use C99 // comments X 2
> > ERROR: trailing statements should be on next line
> > ERROR: trailing whitespace
> > ERROR: switch and case should be at the same indent
> > WARNING: line over 80 characters
> > 
> > total: 5 errors, 4 warnings
> > 
> > Also removed dead code
> > 
> > Also used pr_err() to avoid line breaks
> > 
> > Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@...il.com>
> 
> Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>

Thanks.

If you want I can also fix another ide files.

David, is it OK.

Please let me know which tree I should use bart or David.

Thanks,
--
JSR

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/