linux-kernel - Re: [PATCH 01/64] driver core: set default SYSFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090624150227.GA1784@ucw.cz>
Date:	Wed, 24 Jun 2009 17:02:27 +0200
From:	Pavel Machek <pavel@....cz>
To:	Greg Kroah-Hartman <gregkh@...e.de>
Cc:	linux-kernel@...r.kernel.org, Kay Sievers <kay.sievers@...y.org>
Subject: Re: [PATCH 01/64] driver core: set default SYSFS_DEPRECATED=n

Hi!

> All recent distros depend on the non-deprecated sysfs layout, so
> change the default value of the option to reflect that.
> 
> Signed-off-by: Kay Sievers <kay.sievers@...y.org>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...e.de>
> ---
>  init/Kconfig |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index fed6dc3..c4b3c6d 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -616,13 +616,13 @@ config SYSFS_DEPRECATED
>  	bool
>  
>  config SYSFS_DEPRECATED_V2
> -	bool "Create deprecated sysfs layout for older userspace tools"
> +	bool "remove sysfs features which may confuse old userspace tools"

Should begin with capital letter. What is worse, this inverts sense of
description text, but you did not change semantics of the option.

>  	depends on SYSFS
> -	default y
> +	default n
>  	select SYSFS_DEPRECATED
>  	help
>  	  This option switches the layout of sysfs to the deprecated
> -	  version.
> +	  version. Do not use it on recent distributions.

Recent is relative. 'On distros from 2008 and onwards'?
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/