linux-kernel - Re: [PATCH] alpha: fix percpu build breakage

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090628155011.GA12726@jurassic.park.msu.ru>
Date:	Sun, 28 Jun 2009 19:50:13 +0400
From:	Ivan Kokshaysky <ink@...assic.park.msu.ru>
To:	Tejun Heo <tj@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>, max@...o.at,
	linux-kernel@...r.kernel.org, dhowells@...hat.com
Subject: Re: [PATCH] alpha: fix percpu build breakage

On Sun, Jun 28, 2009 at 09:21:17PM +0900, Tejun Heo wrote:
> Oh... the newest incarnation looks like the following.
> 
> #if defined(ARCH_NEEDS_WEAK_PER_CPU) || defined(CONFIG_DEBUG_FORCE_WEAK_PER_CPU)
> #define DECLARE_PER_CPU_SECTION(type, name, sec)			\
> 	extern __PCPU_DUMMY_ATTRS char __pcpu_scope_##name;		\
> 	extern __PCPU_ATTRS(sec) __weak __typeof__(type) per_cpu__##name
> 
> #define DEFINE_PER_CPU_SECTION(type, name, sec)				\
> 	__PCPU_DUMMY_ATTRS char __pcpu_scope_##name;			\
> 	__PCPU_DUMMY_ATTRS char __pcpu_unique_##name;			\
> 	__PCPU_ATTRS(sec) __weak __typeof__(type) per_cpu__##name
> #else
> #define DECLARE_PER_CPU_SECTION(type, name, sec)			\
> 	extern __PCPU_ATTRS(sec) __typeof__(type) per_cpu__##name
> 
> #define DEFINE_PER_CPU_SECTION(type, name, sec)				\
> 	__PCPU_ATTRS(sec) __typeof__(type) per_cpu__##name
> #endif
> 
> So, I can simply drop __weak from the declaration like the following.
> Looks good?

Yeah, thanks, Tejun.

Ivan.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/