linux-kernel - [PATCH 4/8] drivers/staging/vt6656/main_usb.c: Drop obsolete fsuid/fsgid accesses.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090628170307.GG9143@alittletooquiet.net>
Date:	Sun, 28 Jun 2009 13:03:07 -0400
From:	Forest Bond <forest@...ttletooquiet.net>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	Greg KH <greg@...ah.com>, Larry Finger <Larry.Finger@...inger.net>,
	Alexander Beregalov <a.beregalov@...il.com>,
	Woody Suwalski <woodys@...dros.com>,
	Gábor Stefanik <netrolller.3d@...il.com>,
	Harald Welte <HaraldWelte@...tech.com>,
	"Luis R. Rodriguez" <mcgrof@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: [PATCH 4/8] drivers/staging/vt6656/main_usb.c: Drop obsolete
	fsuid/fsgid accesses.

[Greg: This patch series does not differ from that which you already have.]

drivers/staging/vt6656/main_usb.c: Drop obsolete fsuid/fsgid accesses.

Signed-off-by: Forest Bond <forest@...ttletooquiet.net>
---
 drivers/staging/vt6656/main_usb.c |   13 +++++++++----
 1 files changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/vt6656/main_usb.c b/drivers/staging/vt6656/main_usb.c
index 3368e83..f181d23 100644
--- a/drivers/staging/vt6656/main_usb.c
+++ b/drivers/staging/vt6656/main_usb.c
@@ -1655,15 +1655,17 @@ static UCHAR *Config_FileOperation(PSDevice pDevice) {
     UCHAR    *buffer=NULL;
     struct file   *filp=NULL;
     mm_segment_t old_fs = get_fs();
-    int oldfsuid=0,oldfsgid=0;
+    //int oldfsuid=0,oldfsgid=0;
     int result=0;
 
     set_fs (KERNEL_DS);
-//Make sure a caller can read or write power as root
-   oldfsuid=current->fsuid;
-   oldfsgid=current->fsgid;
+    /* Can't do this anymore, so we rely on correct filesystem permissions:
+    //Make sure a caller can read or write power as root
+    oldfsuid=current->fsuid;
+    oldfsgid=current->fsgid;
     current->fsuid = 0;
     current->fsgid = 0;
+    */
 
     //open file
       filp = filp_open(config_path, O_RDWR, 0);
@@ -1697,8 +1699,11 @@ error1:
 
 error2:
   set_fs (old_fs);
+
+  /*
   current->fsuid=oldfsuid;
   current->fsgid=oldfsgid;
+  */
 
 if(result!=0) {
     if(buffer)
-- 
1.5.6.3


-- 
Forest Bond
http://www.alittletooquiet.net
http://www.pytagsfs.org

Download attachment "signature.asc" of type "application/pgp-signature" (190 bytes)