linux-kernel - Re: [PATCH] PCAP touchscreen driver (for 2.6.32)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1246211366.20525.12.camel@brutus>
Date:	Sun, 28 Jun 2009 14:49:26 -0300
From:	Daniel Ribeiro <drwyrm@...il.com>
To:	Trilok Soni <soni.trilok@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	openezx-devel <openezx-devel@...ts.openezx.org>,
	Harald Welte <laforge@...monks.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] PCAP touchscreen driver (for 2.6.32)

Em Dom, 2009-06-28 às 12:45 +0530, Trilok Soni escreveu:
> 2009/6/27 Daniel Ribeiro <drwyrm@...il.com>:
> > Touchscreen driver for PCAP2 PMIC.

> Some more description in commit text really helps.

Well, there isn't much to say. :) Its a touchscreen driver for a
proprietary PMIC on Motorola phones.

> > +       err = request_irq(pcap_to_irq(pcap_ts->pcap, PCAP_IRQ_TS),
> > +                       pcap_ts_event_touch, 0, "Touch Screen", pcap_ts);
> > +       if (err)
> > +               goto fail;
> > +
> > +       err = input_register_device(pcap_ts->input);
> > +       if (err)
> > +               goto fail_touch;
> 
> Please move request_irq after input_register_device, as IRQ can get
> fired before input device gets available, right?

Yes, you are right, I will move it.

> Overall driver is nice and clean.

Thanks for the review! :)

-- 
Daniel Ribeiro

Download attachment "signature.asc" of type "application/pgp-signature" (198 bytes)