linux-kernel - Re: [PATCH 00/62] Remove unnecessary semicolons

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090628114548.2751f7df@infradead.org>
Date:	Sun, 28 Jun 2009 11:45:48 -0700
From:	Arjan van de Ven <arjan@...radead.org>
To:	David Miller <davem@...emloft.net>
Cc:	joe@...ches.com, linux-kernel@...r.kernel.org, trivial@...nel.org,
	akpm@...ux-foundation.org
Subject: Re: [PATCH 00/62] Remove unnecessary semicolons

On Sun, 28 Jun 2009 11:32:34 -0700 (PDT)
David Miller <davem@...emloft.net> wrote:

> From: Arjan van de Ven <arjan@...radead.org>
> Date: Sun, 28 Jun 2009 10:43:32 -0700
> 
> > On Sun, 28 Jun 2009 10:16:05 -0700
> > Joe Perches <joe@...ches.com> wrote:
> > 
> >> On Sun, 2009-06-28 at 10:11 -0700, Arjan van de Ven wrote:
> >> > can you improve your descriptions please?
> >> > to at least include the why for a change, not just the how and
> >> > what...
> >> 
> >> Is any part of "Remove unnecessary semicolons" unclear?
> >> 
> >> What would you prefer?
> >> 
> > 
> > your sentence addresses the what question, no the why question
> > 
> I think you're going overboard in these requirements.
> 
> Extraneous semi-colons dirty up the code, make it confusing and make
> hard to find bugs more likely to be present or (even worse) get added
> unintentionally in the future.

... and this sentence would have been a really good changelog.


-- 
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/