linux-kernel - Re: PROBLEM: USB ACM device does not work

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200906282258.08277.oliver@neukum.org>
Date:	Sun, 28 Jun 2009 22:58:07 +0200
From:	Oliver Neukum <oliver@...kum.org>
To:	Arseniy Lartsev <ars3n@...dex.ru>,
	USB list <linux-usb@...r.kernel.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: PROBLEM: USB ACM device does not work

Am Sonntag, 28. Juni 2009 20:29:26 schrieb Arseniy Lartsev:
> The reason is that the driver calls usb_submit_urb in acm_start_wb()
> but doesn't set interval in the urb structure, so it remains zero and
> causes usb_submit_urb to return -EINVAL. Reading from device also does

That simply does not make sense. Have you confirmed that this check:

	switch (xfertype) {
	case USB_ENDPOINT_XFER_ISOC:
	case USB_ENDPOINT_XFER_INT:
		/* too small? */
		if (urb->interval <= 0)
			return -EINVAL;

really triggers?

	Regards
		Oliver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/