linux-kernel - Re: [PATCH] exec: Make do_coredump more robust and safer when using pipes in core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m1hby0qahq.fsf@fess.ebiederm.org>
Date:	Sun, 28 Jun 2009 15:06:25 -0700
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	Andi Kleen <andi@...stfloor.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Neil Horman <nhorman@...driver.com>,
	linux-kernel@...r.kernel.org, earl_chew@...lent.com,
	Oleg Nesterov <oleg@...hat.com>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH] exec: Make do_coredump more robust and safer when using pipes in core_pattern

Andi Kleen <andi@...stfloor.org> writes:

>> Andrew should I toss all 100 or so patches over the wall to you
>> and your -mm tree?  Or should I maintain a public git tree based
>> at 2.6.31-rc1?  Get it into linux-next and ask Linus to pull it when
>> the merge window comes?
>
> What do these 100 odd patches do exactly? 

Mostly a fine grained killing of ctl_name, and strategy.

> I think DEFINE_SYSCTL()/ELF section would be the correct direction to go
> for all global variable sysctls.

Perhaps.  I don't know how those data structures interact with
what we have in kernel and in modules.

> Then the binary sysctls could be handled by a global table
> in a separate file like you described

Getting the binary sysctl crud out of the core path should
happen first.  That is just a handful of patches.

> For dynamically generated sysctls (relatively rare but there) 
> the current interfaces are not great, but could be probably kept.

Things like register_sysctl_path can be greatly improved.  Now
that we don't have to worry about the binary paths.

> That all doesn't really need 100 patches though.

If you want the patches to be small enough to be human readable it
takes a lot.  If you want the patches to be CC'able to the appropriate
maintainers and you don't want to require them to weed through a bunch of
irrelevant code it takes a lot.

Typos are a real danger in an operation like this.

Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/