linux-kernel - Re: [PATCH] PCAP touchscreen driver (for 2.6.32)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d5443650906280015x4bddefa5v9dd36f888c5f2e92@mail.gmail.com>
Date:	Sun, 28 Jun 2009 12:45:17 +0530
From:	Trilok Soni <soni.trilok@...il.com>
To:	Daniel Ribeiro <drwyrm@...il.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org,
	linux-kernel <linux-kernel@...r.kernel.org>,
	openezx-devel <openezx-devel@...ts.openezx.org>,
	Harald Welte <laforge@...monks.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [PATCH] PCAP touchscreen driver (for 2.6.32)

Hi Daniel,

2009/6/27 Daniel Ribeiro <drwyrm@...il.com>:
> Touchscreen driver for PCAP2 PMIC.
>

Some more description in commit text really helps.

> +static irqreturn_t pcap_ts_event_touch(int pirq, void *data)
> +{
> +       struct pcap_ts *pcap_ts = data;
> +
> +       if (pcap_ts->read_state == PCAP_ADC_TS_M_STANDBY) {
> +               pcap_ts->read_state = PCAP_ADC_TS_M_PRESSURE;
> +               schedule_delayed_work(&pcap_ts->work, 0);
> +       }
> +       return IRQ_HANDLED;
> +}
> +
> +static int __devinit pcap_ts_probe(struct platform_device *pdev)
> +{
> +       struct input_dev *input_dev;
> +       struct pcap_ts *pcap_ts;
> +       int err = -ENOMEM;
> +
> +       pcap_ts = kzalloc(sizeof(*pcap_ts), GFP_KERNEL);
> +       if (!pcap_ts)
> +               return err;
> +
> +       pcap_ts->pcap = platform_get_drvdata(pdev);
> +       platform_set_drvdata(pdev, pcap_ts);
> +
> +       input_dev = input_allocate_device();
> +       if (!pcap_ts || !input_dev)
> +               goto fail;
> +
> +       INIT_DELAYED_WORK(&pcap_ts->work, pcap_ts_work);
> +
> +       pcap_ts->read_state = PCAP_ADC_TS_M_STANDBY;
> +
> +       pcap_ts->input = input_dev;
> +
> +       input_dev->name = "pcap-touchscreen";
> +       input_dev->phys = "pcap_ts/input0";
> +       input_dev->id.bustype = BUS_HOST;
> +       input_dev->id.vendor = 0x0001;
> +       input_dev->id.product = 0x0002;
> +       input_dev->id.version = 0x0100;
> +       input_dev->dev.parent = &pdev->dev;
> +
> +       input_dev->evbit[0] = BIT_MASK(EV_KEY) | BIT_MASK(EV_ABS);
> +       input_dev->keybit[BIT_WORD(BTN_TOUCH)] = BIT_MASK(BTN_TOUCH);
> +       input_set_abs_params(input_dev, ABS_X, X_AXIS_MIN, X_AXIS_MAX, 0, 0);
> +       input_set_abs_params(input_dev, ABS_Y, Y_AXIS_MIN, Y_AXIS_MAX, 0, 0);
> +       input_set_abs_params(input_dev, ABS_PRESSURE, PRESSURE_MIN,
> +                            PRESSURE_MAX, 0, 0);
> +
> +       err = request_irq(pcap_to_irq(pcap_ts->pcap, PCAP_IRQ_TS),
> +                       pcap_ts_event_touch, 0, "Touch Screen", pcap_ts);
> +       if (err)
> +               goto fail;
> +
> +       err = input_register_device(pcap_ts->input);
> +       if (err)
> +               goto fail_touch;

Please move request_irq after input_register_device, as IRQ can get
fired before input device gets available, right?

Overall driver is nice and clean.

-- 
---Trilok Soni
http://triloksoni.wordpress.com
http://www.linkedin.com/in/triloksoni
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/