linux-kernel - Re: [PATCH] headers_check fix: linux/netfilter/xt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20090628095637.GA651@ioremap.net>
Date:	Sun, 28 Jun 2009 13:56:37 +0400
From:	Evgeniy Polyakov <zbr@...emap.net>
To:	Sam Ravnborg <sam@...nborg.org>
Cc:	Jaswinder Singh Rajput <jaswinder@...nel.org>,
	Patrick McHardy <kaber@...sh.net>,
	David Miller <davem@...emloft.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] headers_check fix: linux/netfilter/xt_osf.h

On Sun, Jun 28, 2009 at 12:00:07AM +0200, Sam Ravnborg (sam@...nborg.org) wrote:
> What about the other potential issues in the same file?
> struct xt_osf_opt {
>         __u16                   kind, length;
>         struct xt_osf_wc        wc;
> };
> 
> Do we know that struct xt_osf_wc is always aligned at a two byte
> address also on 64 bit?

Why 2 bytes? It is 4 bytes aligned everywhere everytime.

> Do we know that sizeof(struct xt_osf_opt) is the same
> on all platforms?

Yes.

> struct xt_osf_user_finger {
>         struct xt_osf_wc        wss;
> 
>         __u8                    ttl, df;
>         __u16                   ss, mss;
>         __u16                   opt_num;
> 
>         char                    genre[MAXGENRELEN];
>         char                    version[MAXGENRELEN];
>         char                    subtype[MAXGENRELEN];
> 
>         /* MAX_IPOPTLEN is maximum if all options are NOPs or EOLs */
>         struct xt_osf_opt       opt[MAX_IPOPTLEN];
> };
> 
> Do we know that opt[MAX_IPOPTLEN] always start at the same offset
> with different architectures?

Yes.

> struct xt_osf_nlmsg {
>         struct xt_osf_user_finger       f;
>         struct iphdr            ip;
>         struct tcphdr           tcp;
> };
> 
> We do not knwo struct iphdr/tcphdr - missing include.
> Do we know the alignment of the above structs?
> Are they always the same on all archs?

You won't believe...

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/