linux-kernel - Re: [PATCH -tip RESEND] perf_counter x86: fix cache_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20090628133745.GA1942@elte.hu>
Date:	Sun, 28 Jun 2009 15:37:45 +0200
From:	Ingo Molnar <mingo@...e.hu>
To:	Jaswinder Singh Rajput <jaswinder@...nel.org>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Peter Zijlstra <peterz@...radead.org>,
	x86 maintainers <x86@...nel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -tip RESEND] perf_counter x86: fix cache_event_ids table


* Jaswinder Singh Rajput <jaswinder@...nel.org> wrote:

> + [C(L1D,  READ,     ACCESS)] = 0x0f40, /* L1D_CACHE_LD.MESI		*/
> + [C(L1D,  READ,     MISSES)] = 0x0140, /* L1D_CACHE_LD.I_STATE		*/

Dont you see how weird 'access' versus 'misses' reads?

Also, i like the PowerPC style more:

static int mpc7450_cache_events[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = 
{
        [C(L1D)] = {            /*      RESULT_ACCESS   RESULT_MISS */
                [C(OP_READ)] = {        0,              0x225   },
                [C(OP_WRITE)] = {       0,              0x227   },
                [C(OP_PREFETCH)] = {    0,              0       },
        },
        [C(L1I)] = {            /*      RESULT_ACCESS   RESULT_MISS */
                [C(OP_READ)] = {        0x129,          0x115   },
                [C(OP_WRITE)] = {       -1,             -1      },
                [C(OP_PREFETCH)] = {    0x634,          0       },
        },

See how readable a two dimensional array is?

If we change the definitions on x86 then i'd suggest a small variant 
of this:

        [C(L1D)] = {          /* {  ACCESS         MISS   } */
                [C(READ    )]  = {       0,       0x225   },
                [C(WRITE   )]  = {       0,       0x227   },
                [C(PREFETCH)]  = {       0,           0   },
        },

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/