linux-kernel - Re: kmemleak reports firmware loader funnies in iwlwifi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f020906290248w474ad2ffpe6a8b5bede3d2c20@mail.gmail.com>
Date:	Mon, 29 Jun 2009 12:48:29 +0300
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Catalin Marinas <catalin.marinas@....com>
Cc:	Dave Jones <davej@...hat.com>, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org
Subject: Re: kmemleak reports firmware loader funnies in iwlwifi

Hi Catalin,

On Mon, Jun 29, 2009 at 12:39 PM, Catalin
Marinas<catalin.marinas@....com> wrote:
> diff --git a/drivers/base/firmware_class.c b/drivers/base/firmware_class.c
> index ddeb819..26fb808 100644
> --- a/drivers/base/firmware_class.c
> +++ b/drivers/base/firmware_class.c
> @@ -179,6 +179,13 @@ static ssize_t firmware_loading_store(struct device *dev,
>                                dev_err(dev, "%s: vmap() failed\n", __func__);
>                                goto err;
>                        }
> +                       /*
> +                        * This block of memory is later freed using vfree.
> +                        * Since kmemleak does not track vmap calls, just
> +                        * inform it about this block but ignore it during
> +                        * scanning.
> +                        */
> +                       kmemleak_alloc(fw_priv->fw->data, 0, -1, GFP_KERNEL);
>                        /* Pages will be freed by vfree() */
>                        fw_priv->pages = NULL;
>                        fw_priv->page_array_size = 0;

Would it be possible to put this hook in vmap() somehow?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/